FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix outdated comment by richardipsum · Pull Request #3869 · libgit2/libgit2 · GitHub

Repository navigation

Fix outdated comment - #3869

Merged
ethomson merged 2 commits into
libgit2:masterfrom
richardipsum:fix-outdated-comment
Aug 4, 2016
Merged

ethomson merged 2 commits into
libgit2:masterfrom
richardipsum:fix-outdated-comment

Conversation

Copy link
Copy Markdown
Contributor

Hey,

So this is a very trivial pr,
the original comment is from 2012 and seems to no longer apply.
The contribution guidelines suggest // style comments should be avoided,
so I figure I may as well fix that up while I'm here.

Apologies if this is a waste of reviewer time,
but I was working in the perl binding and this comment misled me.

Hope this helps! :)

SSH transport seems to be supported now.
Style guide says // style comments should be avoided.

ethomson commented Aug 4, 2016

Copy link
Copy Markdown
Member

Thanks for your careful eye! :D

ethomson merged commit 0d84de0 into libgit2:master Aug 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL