Repository navigation
[WIP] Travis Mac SSH key issues - #3954
Merged
carlosmn merged 2 commits intoOct 5, 2016
Merged
carlosmn merged 2 commits into
carlosmn merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This lets us see the details of what we're doing instead of just seeing the output of unknown commands in the build output.
Copy link
Copy Markdown
Member
Author
|
It looks like the newer ssh or ssh-keygen now lists the SHA256, base64-encoded by default. Unfortunately libssh2 only supports MD5 and SHA1 for the fingerprint so that's what we're going to have to ask for on Mac, until the ssh version on Ubuntu caches up. |
Sorry, something went wrong.
The Mac machines have updated their SSH version and so the ssh-keygen format has changed. Ask it for MD5, which is the one that is output as hex.
carlosmn
force-pushed
the
cmn/osx-ssh-key
branch
from
2d43b41 to
db35766
Compare
October 5, 2016 18:24
arthurschreiber
approved these changes
Oct 5, 2016
arthurschreiber
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! 👍🏻
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're failing this check and I'm trying to figure out why. It might just be that the format from ssh-keygen changed so we need to account for that in our tests.