Repository navigation
Fix the existence check for regcomp_l. - #3955
Merged
carlosmn merged 1 commit intoOct 7, 2016
Merged
carlosmn merged 1 commit into
carlosmn merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
arthurschreiber
force-pushed
the
arthur/fix-regcomp_l-check
branch
from
994252c to
a6960bf
Compare
October 7, 2016 18:42
Copy link
Copy Markdown
Member
Author
|
@carlosmn I fixed the tests to actually test with a multibyte locale as well. |
Sorry, something went wrong.
`xlocale.h` only defines `regcomp_l` if `regex.h` was included as well. Also change the test cases to actually test `p_regcomp` works with a multibyte locale.
arthurschreiber
force-pushed
the
arthur/fix-regcomp_l-check
branch
from
b2f4f30 to
3611797
Compare
October 7, 2016 19:47
Copy link
Copy Markdown
Member
|
It's really annoying that we need code like this, but yeah let's merge it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xlocale.h only defines regcomp_l if regex.h was included as well.
@carlosmn I have NO idea why the unit tests were passing - looks like they are not really testing this?! 😕