Repository navigation
Update THREADING for OpenSSL 1.1 - #3985
Merged
carlosmn merged 2 commits intoNov 14, 2016
Merged
carlosmn merged 2 commits into
carlosmn merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
👍 from me - I'll leave this open for a hot minute in case somebody else has some input. |
Sorry, something went wrong.
pks-t
reviewed
Nov 4, 2016
pks-t
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good besides the spotted typo
Sorry, something went wrong.
Comment thread
THREADING.md
Outdated
| [recommendations for thread safety](https://curl.haxx.se/libcurl/c/threadsafe.html). | ||
|
|
||
| If there are no alternative TLS implementations (currently only | ||
| SecureTransport), libgit2 uses OpenSSL in order to use HTTPS as a trasnport. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
There's a typo in "trasnport"
Sorry, something went wrong.
carlosmn
force-pushed
the
cmn/threading-update
branch
from
3ea3b1d to
f7d316e
Compare
November 4, 2016 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting at OpenSSL 1.1.0 it is thead-safe by itself, so mention that for people linking against it, they do not need to take further steps.
Also update the cURL link which has changed its location.
I've tried to reword things a bit to make it clearer (and remove a "may" for our last-resort locking function which might be taken as too much of a promise) but knowing what to do in order to use the network safely is still a minefield where you might need to initialise threading for two different libraries, and you don't know whether you have to until runtime.