Repository navigation
giterr format - #4002
Merged
carlosmn merged 5 commits intoNov 14, 2016
Merged
giterr format#4002carlosmn merged 5 commits into
carlosmn merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
While this shouldn't have any effect on that issue as the address of a struct is the address of its first field, it's a good idea to tell the compiler about the printf format and fix its warnings. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Nice, thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While inspecting #4000, I've been very surprised to find out that we were passing a git_buf pointer to giterr_set without any warning of the compiler. Seems we didn't put a printf-attribute hint at the declaration, causing the compiler to accept whatever we put there.
Next to the many cases of "%d" instead of "%"PRIuZ which can cause us to overflow in the output, there were also three real errors where we passed a structure pointer to "%s" instead of the real value.