Repository navigation
Use the sorted input in the tree updater - #4003
Merged
ethomson merged 3 commits intoNov 14, 2016
Merged
ethomson merged 3 commits into
ethomson merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
We do not currently use the sorted version of this input in the function, which means we produce bad results.
The loop is made with the assumption that the inputs are sorted and not using it leads to bad outputs.
We look at whether we're trying to replace a blob with a tree during the update phase, but we fail to look at whether we've just inserted a blob where we're now trying to insert a tree. Update the check to look at both places. The test for this was previously succeeding due to the bu where we did not look at the sorted output.
Copy link
Copy Markdown
Member
|
👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop/algo is made to assume that we have sorted inputs. We sort them to make sure but we failed to actually use the sorted list. The tests were inadvertently written with inputs that did not show this bad behaviour.
This fixes #3804