Repository navigation
Properly pass wchar * type to giterr_set - #4014
ethomson merged 2 commits into
Conversation
Sorry, something went wrong.
| * not counting the NULL terminator */ | ||
| if ((st->st_size = git__utf16_to_8(NULL, 0, target)) < 0) { | ||
| giterr_set(GITERR_OS, "Could not convert reparse point name for '%s'", path); | ||
| giterr_set(GITERR_OS, "Could not convert reparse point name for '%S'", path); |
There was a problem hiding this comment.
Good catch.
IIRC, %S means that the argument should have the opposite size of the format string. So for the narrow printf family of functions, %S is a wchar_t * and for the Unicode/wide wprintf family of functions, %S is a narrow char *. Is my memory correct here?
If so, can we change this to %ls which (again, IIRC) indicates a wide string always, regardless of whether you're feeding it to printf or wprintf.
Sorry, something went wrong.
There was a problem hiding this comment.
Just checked with MinGW 5.3.0, and, you are right. %S seem to reverse the character width.
So, yes %ls format is better for this case.
Sorry, something went wrong.
|
Thanks! 😀 |
Sorry, something went wrong.
Ensure correct type is passed, no garbage text is sent, and mute compiler warning.