FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WinHTTP: support best auth mechanism by ethomson · Pull Request #4055 · libgit2/libgit2 · GitHub

  1. libgit2
  2. libgit2

Repository navigation

WinHTTP: support best auth mechanism - #4055

Merged
carlosmn merged 1 commit into
libgit2:masterfrom
ethomson:ethomson/ntlm
Jan 16, 2017
ConversationCommits (1)ChecksFiles changed
Merged

WinHTTP: support best auth mechanism#4055
carlosmn merged 1 commit into
libgit2:masterfrom
ethomson:ethomson/ntlm

Conversation

ethomson commented Dec 30, 2016

Copy link
Copy Markdown
Member

For username/password credentials, support NTLM or Basic (in that order of priority). Use the WinHTTP built-in authentication support for both, and maintain a bitfield of the supported mechanisms from the response.

Fixes #4039

ghost commented Jan 16, 2017

Copy link
Copy Markdown

Any chance someone can pull in this one soon? It's blocking for users of Gitkraken who have upgraded their TFS servers to 2017.

WinHTTP: support best auth mechanism
4e4a146 
For username/password credentials, support NTLM or Basic (in that order
of priority).  Use the WinHTTP built-in authentication support for both,
and maintain a bitfield of the supported mechanisms from the response.

ethomson commented Jan 16, 2017

Copy link
Copy Markdown
Member Author

FYI @carlosmn - I rebased this to resolve conflicts.

carlosmn merged commit df4dfaa into libgit2:master Jan 16, 2017

MustafaJamal commented Jan 20, 2017

Copy link
Copy Markdown

After fixing of this issue, when we should expect the fixing of following LibGit2Sharp issue:

libgit2/libgit2sharp#1168

Can anyone please tell me as we are facing issues when using LibGit2Sharp with TFS2015/TFS2017.

Thanks!

johnhaley81 mentioned this pull request Feb 6, 2017
Merged
tkelman mentioned this pull request Jul 5, 2017
Merged

tkelman commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

We can try to reduce this and report on its own, but x-ref JuliaLang/julia#22681 we're seeing that after this change an empty username and password now gives a generic GIT_ERROR on Windows, whereas on other platforms (and Windows on prior versions of libgit2) it gives GIT_EAUTH. Is this an expected behavior change?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL