Repository navigation
Flag checkout_opts in git_reset as optional - #4109
Merged
ethomson merged 1 commit intoFeb 8, 2017
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The check_outs argument can be NULL and should be flagged accordingly in the header file.
Copy link
Copy Markdown
Member
|
Thanks! I really appreciate you going through the docs here - these are things that really help people get started with using the library. ❤️ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for git_reset doesn't state that check-out_opts can be optional in its documentation. However, if you look at a test file you will see that NULL is used everywhere.
The header file should be updated to reflect that check_opts is actually an optional argument.