Repository navigation
Improve clar messages - #4130
ethomson merged 3 commits into
Conversation
Sorry, something went wrong.
`snprintf` requires a _format_ but does not require _arguments_ to the
format. eg: `snprintf(buf, 42, "hi")` is perfectly legal. Expand the
macro to match.
Without this, `p_sprintf(buf, 42, "hi")` errors with:
```
error: expected expression
p_snprintf(msg, 42, "hi");
^
src/unix/posix.h:53:34: note: expanded from macro 'p_snprintf'
^
/usr/include/secure/_stdio.h:57:73: note: expanded from macro 'snprintf'
__builtin___snprintf_chk (str, len, 0, __darwin_obsz(str),
__VA_ARGS__)
```
|
The goal here is to see more information about why some tests fail in appveyor. We expect certificate failures, but are getting a generic -1 failure. Shoddy networking, but it would be interesting to see a bit more details. |
Sorry, something went wrong.
|
Very nice. You forgot to modfiy all existing callsites of cl_git_report_failure ;) What do you think about using cl_git_expect instead of cl_git_exec as the macro's name? |
Sorry, something went wrong.
Provide more detailed messages when conditions pass or fail unexpectedly. In particular, this provides the error messages when a test fails with a different error code than was expected.
|
I did forget win32! Oops! I had this as cl_git_expect or something similar to begin with, so I was rather on the fence. It sounds like you prefer that, so I've changed cl_git_exec -> cl_git_expect. |
Sorry, something went wrong.
|
cl_git_exec did not really sound as if it would check anything but only execute a function. So I think cl_git_expect makes the function a bit more obvious in its behavior. Thanks, looks good to me. |
Sorry, something went wrong.
Provide more detailed messages when conditions pass or fail unexpectedly. In particular, this provides the error messages when a test fails with a different error code than was expected.
cl_git_pass failures look unchanged:
cl_git_fail messages now:
cl_git_fail_with messages now:
/cc @pks-t