The AppVeyor mingw builds are busted at the moment. I'm looking into it; please ignore build failures from those hosts for now.

Looks good; only one minor problem: we want to make sure to turn GIT_OPT_ENABLE_STRICT_SYMBOLIC_REF_CREATION back to its default after this test runs.

Can you add:

cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_SYMBOLIC_REF_CREATION, 1));

to the cleanup routine in test_refs_create__cleanup?

Thanks!

I noticed some whitespace/style issues while I was doing that so I fixed them up and tacked them on as an extra commit.

For what it's worth while rerunning the test suite locally, just to be sure, I notice that the clar tests fail if run via the Makefile but not when run directly, this happens on master as well so I'm pretty sure it's unrelated to my changes.

I have some free time today so I might check out why that's happening.

I think the tests are failing due to networking issues at my end, so nothing to worry about. I needed to do some googling to figure out how to get the tests to print the exact failure to the screen without manually modifying the generated Makefile. I've submitted #4139 to add a note to the README on how to do this.

Cool, thanks! 😀