Repository navigation
Correct non-existent file references in odb.h - #4188
Merged
ethomson merged 1 commit intoApr 3, 2017
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for fixing this! I wonder if the confusion here isn't because the file is in the sys directory? Maybe we should say sys/odb_backend.h... what do you think? |
Sorry, something went wrong.
There are references to odb_backends.h when the file is actually named odb_backend.h and in the sys folder.
Copy link
Copy Markdown
Contributor
Author
|
Good point! Makes sense to me. I've force pushed your suggested change to my branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
👍 Thanks for taking care of this! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #4187.