#6028: Check if threadstate->error_t.message is not git_buf__initbuf before freeing. - #6029
Merged
ethomson merged 1 commit intoSep 3, 2021
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…__initbuf` before freeing. This follows the same principle as `buffer.c` where the same check is done before freeing the buffer. It fixes the crash described in libgit2#6028.
ethomson
reviewed
Sep 3, 2021
Comment thread
src/threadstate.c
Comment on lines
+39
to
+40
| if (threadstate->error_t.message != git_buf__initbuf) | ||
| git__free(threadstate->error_t.message); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM - just a quick whitespace fix:
Suggested change
| if (threadstate->error_t.message != git_buf__initbuf) | |
| git__free(threadstate->error_t.message); | |
| if (threadstate->error_t.message != git_buf__initbuf) | |
| git__free(threadstate->error_t.message); |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for tracking this down! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the same principle as buffer.c where the same check is done before freeing the buffer. It fixes the crash described in #6028.