Use __typeof__ GNUC keyword for ISO C compatibility - #6041
Merged
ethomson merged 1 commit intoSep 14, 2021
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
does clang with -std=c99 build cleanly after this change? if so, maybe it may be worth (in a separate PR) adding -std=c99 to the xenial builders in .github/workflows/main.yml. that way we won't backslide ^^;; |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Nice catch, thanks for the fix! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue: #6040
This PR converges on the use of __typeof__ instead of typeof for ISO C compatibility with this GCC extension.
All uses of typeof or __typeof__ are presently confined to #if defined(__GNUC__) / #endif blocks, which should limit the impact of this change.
Details: