Add test to ensure empty proxy env behaves like unset env - #6052
Merged
ethomson merged 1 commit intoSep 20, 2021
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
ethomson
reviewed
Sep 20, 2021
Comment thread
tests/remote/httpproxy.c
|
|
||
| /* empty env behaves like unset env */ | ||
| cl_setenv("HTTPS_PROXY", ""); | ||
| assert_proxy_is(NULL); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I dug in to the test failures because I thought that the proxy detection code was returning "" as the proxy or something, it was not.
This check needs to happen above the configuration change (or should otherwise undo the configuration change at line 138). The configuration overrides the environment variable, so this test would never be true.
I moved this up above and merged it. Thanks for the fix! 👍
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.