Longpath filter bug - #6055
Merged
ethomson merged 3 commits intoSep 20, 2021
Merged
Longpath filter bug#6055ethomson merged 3 commits into
ethomson merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ough the filtering code to ensure the cached longpath setting is returned. Fixes: libgit2#6054
ethomson
requested changes
Sep 14, 2021
Copy link
Copy Markdown
Member
|
Looks good to me - we'll need to ifdef around that new function to prevent unused warnings, but otherwise 👍 |
Sorry, something went wrong.
Co-authored-by: Edward Thomson <ethomson@github.com>
Copy link
Copy Markdown
Member
|
Thanks for the fix. I changed the unit test a bit in 005c740 to check the contents in the repo to ensure that filtering was applied. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6054.
An alternative might be to handle the null git_repository case in the longpath check ((bool) should_validate_longpaths(git_repository *repo)). Could also put an assert on "repo" argument in should_validate_longpaths.