Allow proxy options when connecting with a detached remote. - #6058
Merged
ethomson merged 4 commits intoSep 20, 2021
Merged
ethomson merged 4 commits into
ethomson merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lrm29
marked this pull request as ready for review
September 16, 2021 11:17
ethomson
requested changes
Sep 18, 2021
ethomson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think that we can avoid keeping this cleanup_config variable by getting a refcounted pointer for the repository's config, instead of a weak pointer. Then we'll just free it always. There's no real overhead to getting a regular config and git_config_freeing it, the only real advantage to weak pointers is that you don't need to worry about freeing them.
Sorry, something went wrong.
Comment thread
src/remote.c
Outdated
Comment thread
src/remote.c
Outdated
Comment thread
src/remote.c
Outdated
Comment thread
src/remote.c
Outdated
Copy link
Copy Markdown
Member
|
Thanks for this! I might recommend a minor cleanup. |
Sorry, something went wrong.
Co-authored-by: Edward Thomson <ethomson@github.com>
Initialise cfg variable.
Copy link
Copy Markdown
Member
|
Looks good to me! Thanks for the fix! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6059.