| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Good catch! Thanks for the fix. 😀 |
Sorry, something went wrong.
|
do i get a credit for it? :)
i noticed Author: header, in the commit log, is set to this:
`Author: Edward Thomson ***@***.***>`
other projects usually use the Committer/Autor pair.
|
Sorry, something went wrong.
|
I'm not sure what you mean. Your commit has your committer and author information, which is what you pushed up: % git cat-file commit 581cfbd tree 48803cd33cc63c03015446332b04789b3a9e81a7 parent 136901086ecfdd2b5cc106782310355a9c0b1a9a author Paymon MARANDI <darwinskernel@gmail.com> 1632412792 -0400 committer jrun <darwinskernel@gmail.com> 1632507299 -0400 |
Sorry, something went wrong.
i see, thanks. i was looking at git cat-file commit 424812e3d874. |
Sorry, something went wrong.
|
I'm not really doing anything special - 424812e is the merge commit that brought your pull request branch into main. This is the default way pull requests get merged in GitHub - and the equivalent to if I had merged it by running git merge <your branch name>. The person who runs git merge is marked as the committer and author of the merge commit that puts the code into the main branch. If you've seen other behaviors, it may be that people had a rebase or squash based workflow enabled. I don't like those, personally, so I just stick with the GitHub defaults. |
Sorry, something went wrong.
|
i see, thanks.
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.