oidarray: introduce git_oidarray_dispose - #6076
Merged
ethomson merged 1 commit intoSep 27, 2021
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Since users are disposing the _contents_ of the oidarray, not freeing the oidarray itself, the proper cleanup function is `git_oidarray_dispose`. Deprecate `git_oidarray_free`.
ethomson
force-pushed
the
ethomson/oidarray_dispose
branch
from
71936b3 to
0bd132a
Compare
September 26, 2021 22:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since users are disposing the contents of the oidarray, not freeing
the oidarray itself, the proper cleanup function is
git_oidarray_dispose. Deprecate git_oidarray_free.