Ensure throttling does not break capture_scroll - #478
Merged
ianhi merged 1 commit intoFeb 15, 2023
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
|
Sorry, something went wrong.
Merged
ianhi
force-pushed
the
always-capture
branch
from
f6356ed to
3662170
Compare
February 15, 2023 15:20
martinRenou
approved these changes
Feb 15, 2023
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we started throttling mouse events we now also throttle the capture_scroll This PR adds that as a separate EventListener that is not throttled.