FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixup CI by martinRenou · Pull Request #514 · matplotlib/ipympl · GitHub

Fixup CI - #514

Merged
martinRenou merged 8 commits into
matplotlib:mainfrom
martinRenou:fixup_ci
Feb 15, 2023
Merged

Fixup CI#514
martinRenou merged 8 commits into
matplotlib:mainfrom
martinRenou:fixup_ci

Conversation

Copy link
Copy Markdown
Member

No description provided.

github-actions Bot commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

👈 Launch a binder notebook on branch martinRenou/ipympl/fixup_ci

Copy link
Copy Markdown
Member Author

update galata references

ianhi commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

is it possible to easily look at the differences in the generated images? I suspect that were catching a styling change in matplotlib latest

martinRenou commented Feb 9, 2023
edited
Loading

Copy link
Copy Markdown
Member Author

You can download the test artifacts on this page https://github.com/matplotlib/ipympl/actions/runs/4122954626 (bottom of the page -> ui-test-output file). It will contain the expected image, the actual image and the diff.

There seems to be a slight difference in the font rendering of the axis labels.

I suspect that were catching a styling change in matplotlib latest

Yes, I was thinking the same. It seems to only happen on Ubuntu.

Because it's a very slight difference I tried to change the threshold for the diff, without success.

ianhi commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

Yes, I was thinking the same. It seems to only happen on Ubuntu.

I think that there have been a bunch of changes to the font system recently. I almost wonder if this is surfacing a very subtle bug upstream

ianhi commented Feb 15, 2023

Copy link
Copy Markdown
Collaborator

@martinRenou what do you think about merging this now and fixing up the ubuntu latest in the future? As it stands this allows us to run tests, which we otherwise cant. which would be helpful for #517 and #478

Copy link
Copy Markdown
Member Author

That's fine with me, half working CI is better than non working one

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL