| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
wouldn't we only want to do this for 'log'? Also, since bins is a list and the operation is just a simple filter, let's go with that route.
Add a comment for the rationale for the filtering and also for the 0.1 multiplication.
Sorry, something went wrong.
only want to set min this way if log is specified. Also, added case for normed vs not
|
@WeatherGod - I think you're right, you only want to do it this way for log. You also want different minima for normed vs not. |
Sorry, something went wrong.
|
Why 0.1? What is special about that number versus any other number? Could it accidentially be related to the fact that the default number of bins is 10 (I think)? If so, then we can't rely on that. |
Sorry, something went wrong.
|
No, 0.1 corresponds to one tick label unit for log plots assuming log base
|
Sorry, something went wrong.
|
ok, so probably the only thing left is to add a test for this. If you need help with that, just let me know. |
Sorry, something went wrong.
|
It should probably use the log's actual base -- it's 10 by default, but it could be anything. |
Sorry, something went wrong.
|
This should go in v1.2.x, it's a fix. I'm milestoning it as such. @keflavich Are you able to add a test for this? If not I can fork your branch and move this forward. |
Sorry, something went wrong.
|
Best if you go ahead; I'll not have a chance for at least a week |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
A solution was proposed in Issue #196. This pull request implements that proposed solution.