FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix hist for log=True and histtype='step' by dmcdougall · Pull Request #1684 · matplotlib/matplotlib · GitHub

Repository navigation

Fix hist for log=True and histtype='step' - #1684

Merged
dmcdougall merged 6 commits into
matplotlib:v1.2.xfrom
dmcdougall:fix_loghist
Jan 27, 2013
Merged

dmcdougall merged 6 commits into
matplotlib:v1.2.xfrom
dmcdougall:fix_loghist

Conversation

Copy link
Copy Markdown
Member

Rebased version of #1029 to target v1.2.x. This aims to fix #196 but is currently incomplete.

Copy link
Copy Markdown
Member Author

Over in #1029 there was discussion of using the log's actual base rather than the magical number 0.1. This would be the correct solution aside from the fact that the axis scale is set to base ten inside hist (it's the default). If the user then changes the [xy]scale outside of hist, how do we change the plot to reflect the change of base without calling hist again?

Copy link
Copy Markdown
Member

I wouldn't worry too much about a situation where the log base changes
after the call to hist. A lot of stuff breaks if you do any sort of
rescaling after the call to hist, and if it isn't already, it should be
well documented to establish your scales prior to any plotting.

Copy link
Copy Markdown
Member Author

@WeatherGod Alright, thanks for that information.

Are there any other concerns that need to be addressed before this is merged? All tests pass locally on python 2.7.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL