Repository navigation
Deprecate text.latex.unicode. - #11255
Merged
dstansby merged 1 commit intoMay 30, 2018
Merged
dstansby merged 1 commit into
dstansby merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
text.latex.unicode
branch
from
5e5d7eb to
9112b02
Compare
May 15, 2018 17:22
timhoffm
reviewed
May 16, 2018
Comment thread
lib/matplotlib/mpl-data/stylelib/classic.mplstyle
Outdated
| # matplotlib mailing list | ||
| text.latex.unicode : False # use "ucs" and "inputenc" LaTeX packages for handling | ||
| # unicode strings. | ||
| # text.latex.unicode : False # use "ucs" and "inputenc" LaTeX packages for handling |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why is this commented out? Either we leave the setting for the classic style to False (maybe we should?), or we explicitly set it to True.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I decided to just delete them (given that the ultimate goal is to just get rid of the rcs, and that this should not change the result of any plot, just make more plots usetex-compilable).
Sorry, something went wrong.
It is 2018 and Python3 is ruling the world; it is high time for usetex
to default to unicode support as well.
(If ``\usepackage[utf8]{inputenc}`` is irremediably breaking some users'
setup we can always revisit this decision.)
anntzer
force-pushed
the
text.latex.unicode
branch
from
9112b02 to
e9a8120
Compare
May 17, 2018 05:35
timhoffm
approved these changes
May 17, 2018
dstansby
approved these changes
May 30, 2018
Copy link
Copy Markdown
Member
|
Would someone revert this ASAP, please? Or fix the problem it is causing, which is flooding the test output with deprecation warnings? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is 2018 and Python3 is ruling the world; it is high time for usetex
to default to unicode support as well.
See https://tex.stackexchange.com/questions/13067/utf8x-vs-utf8-inputenc
https://groups.google.com/forum/?fromgroups=#!msg/comp.text.tex/4LC-xODb-LU/1Bd5UZOMNM4J
regarding why \usepackage[utf8]{inputenc} is better.
(If \usepackage[utf8]{inputenc} is irremediably breaking some users'
setups we can always revisit this decision.)
PR Summary
PR Checklist