FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Deprecate text.latex.unicode." by tacaswell · Pull Request #11345 · matplotlib/matplotlib · GitHub

Repository navigation

Revert "Deprecate text.latex.unicode." - #11345

Merged
dstansby merged 1 commit into
masterfrom
revert-11255-text.latex.unicode
May 31, 2018
Merged

dstansby merged 1 commit into
masterfrom
revert-11255-text.latex.unicode

Conversation

Copy link
Copy Markdown
Member

Reverts #11255

This is causing a lot of spam on CI. Should be restored along with the internal clean up required.

tacaswell added this to the v3.0 milestone May 31, 2018

anntzer commented May 31, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm almost certain that #11292 would fix the issue (per "Use matplotlib.style.context to restore the style at exit, as it relies on rc_context which is ultimately more efficient than rcParams.update as it skips revalidation"). Triggering a rebuild of that PR now to check.

Sorry for the disturbance.

Copy link
Copy Markdown
Member

I'm going to merge this since it will get rid of all the messages for now, sorry for not checking and merging the original PR.

dstansby merged commit 230a251 into master May 31, 2018
dstansby deleted the revert-11255-text.latex.unicode branch May 31, 2018 10:39
anntzer mentioned this pull request Jun 5, 2018
6 tasks

anntzer commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

I put back a better(?) version in https://github.com/matplotlib/matplotlib/pull/11381/files, would be nice to know how it is causing problems in holoviews (can you provide a repro?).
It's still in rcsetup.py given that, yes, we want people to still be able to access it but have access trigger a deprecation.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL