| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Happy with the change, but I'm not claiming any expertise on the topic. |
Sorry, something went wrong.
|
OK, figured out how to pass the failure up the line. Now lazy_init calles check_framework after the app has started... |
Sorry, something went wrong.
|
... and doesnt' depend on the deprecated calls... |
Sorry, something went wrong.
|
The problem is that for backend fallback to correctly work, we need importing the backend to fail with ImportError; backend fallback (at least as it is written right now) doesn't work with later failures. |
Sorry, something went wrong.
|
OK - see my comment on gitter - it turns out that not having the Framework installed (pythonw) doesn't stop the GUI from working FAICT, it just is slightly suboptimal in that the GUI doesn't have a dock icon, so it can get burried under other windows. To my taste that isnt' something to Error over, but rather we could/should throw a warning. |
Sorry, something went wrong.
|
Well, you have to ask those who put in the check to start with (#1613 and other PRs). |
Sorry, something went wrong.
|
Ah, OK, the issue is #665; if you open the save dialog you can't get typing focus in the dialog box. I'm 50/50 still if that requires us to error or warn, but it can be said to be not fully functional. |
Sorry, something went wrong.
|
@jklymak Afaik we put this in because we got so many errors and spent so much time tracking down why the gui was not working. With pyqt5 and wxpython being pip installable now it seems easier for users to switch to a functioning backend rather than using a semi broken one so I am mildly in favor of erroring out but warnings are fine with me too. |
Sorry, something went wrong.
|
OK, let's try something else. |
Sorry, something went wrong.
There was a problem hiding this comment.
As in comments: raising ImportError should occur when importing the module, not when trying to construct the objects.
Sorry, something went wrong.
Nope, that doesn't work. Newest push just uses the deprecated methods at import. |
Sorry, something went wrong.
|
Merging this as it un-breaks osx for now (and pushing the reckoning of using deprecated APIs to future us). The OSX backend is now agg based like the others (rather than an alternate rendering path) and presumably should also be made to play nice with cairo. The biggest advantage of the OSX backend over tk/wx is that it support hi-dpi. The biggest advantage over Qt is that it is no extra dependencies (on macs). |
Sorry, something went wrong.
…850-on-v3.0.x Backport PR #11850 on branch v3.0.x
| Back | FazBrowse Home | New Git URL |
PR Summary
Closes #11846
In the macosx backend, verify_framework now (post #11600) gets called before the app gets started, so the checks for the framework always fail. This PR, at the suggestion of @anntzer simply uses the old pre 10.6 checks. Not sure this is the correct solution versus moving verify_framework to a point after the app has started, but it does work on my machine (10.13.6); using framework python (pythonw) works, using non-framework python (python) gives the appropriate error.
This PR moves the verify_framework check into lazy_init, where the app is started, and passes success or failure up a level.
PR Checklist