FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simpler check for whether a Framework Python build is being used. by anntzer · Pull Request #11851 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Simpler check for whether a Framework Python build is being used. - #11851

Closed
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:frameworkcheck
ConversationCommits (1)ChecksFiles changed
Closed

Simpler check for whether a Framework Python build is being used.#11851
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:frameworkcheck

Conversation

anntzer commented Aug 13, 2018

Copy link
Copy Markdown
Contributor

This check works even before an NSApp is started.

Simpler alternative to #11850. Basically the first stackoverflow answer for the question (https://stackoverflow.com/questions/15752390/how-to-tell-if-python-instance-was-compiled-as-framework), from a CPython core dev.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Simpler check for whether a Framework Python build is being used.
f5df331 
This check works even before an NSApp is started.
anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: MacOSX labels Aug 13, 2018
anntzer added this to the v3.0 milestone Aug 13, 2018

jklymak commented Aug 13, 2018

Copy link
Copy Markdown
Member

Unfortunately, this doesnt' work w/ my Anaconda pythonw. That config variable is not set even if I use pythonw...

anntzer commented Aug 13, 2018

Copy link
Copy Markdown
Contributor Author

Looks like @efiring knows something about this per http://matplotlib.1069221.n5.nabble.com/Re-Anaconda-Support-OSX-why-not-make-python-invoke-the-framework-tp43793p43806.html :)
(and that anaconda's pythonw is not a real framework build but manually emulates one, whatever that means...)
Oh well.

jklymak commented Aug 13, 2018

Copy link
Copy Markdown
Member

Yeah, I guess anaconda does something funky. OTOH, I shudder to think what installing the framework build w/o anaconda would be like...

anntzer commented Aug 13, 2018

Copy link
Copy Markdown
Contributor Author

Isn't that just (for example) python.org's python? Anyways, the discussion is not very relevant, we're stuck with whatever anaconda did and #11850 seems better unless Apple plans to actually remove their deprecated features :p

tacaswell modified the milestones: v3.0, v3.1 Aug 19, 2018

tacaswell commented Aug 19, 2018

Copy link
Copy Markdown
Member

Moving this to 3.1 as I just merged #11850. I think this is inline with @anntzer 's last comment.

tacaswell removed the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 19, 2018

jklymak commented Nov 12, 2018

Copy link
Copy Markdown
Member

Closing this, as this approach won't work unfortunately...

jklymak closed this Nov 12, 2018
anntzer deleted the frameworkcheck branch November 12, 2018 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

GUI: MacOSX

Projects

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL