Repository navigation
tight_layout : automatic adjustment of subplot params - #124
leejjoon merged 14 commits into
Conversation
Sorry, something went wrong.
|
From reading the docs (haven't read the code yet), I'm wondering if there isn't a way around the final limitation (about colorbars). Why does the layout code only work on Subplot subclasses, and not all Axes subclasses? |
Sorry, something went wrong.
There was a problem hiding this comment.
Is there a good reason to keep this around? It looks like the new version is mainly just a refactoring into get_ticklabel_extents and _get_tick_bboxes.
Sorry, something went wrong.
There was a problem hiding this comment.
No. I meant to remove it when refactoring is done. And I just removed it. Thanks.
Sorry, something went wrong.
|
The reason that it only supports subplots is because it is easy. In general, I don't think we can figure out the intention of the users when they specified the positions of axes. If you (or others) have any idea or suggestions, let me know. |
Sorry, something went wrong.
|
I see. That makes sense. It still would be nice to handle colorbars in a more intuitive way if possible. (Of course, I have no bright ideas right now...) |
Sorry, something went wrong.
There was a problem hiding this comment.
These examples should probably also be included as regression tests.
Sorry, something went wrong.
|
I thought about the issue with colorbar and came up with #126. With this (and w/ above commit f216d0d), tight_layout works for colobar as far as the colorbar is created with use_gridspec=True (the layout may not be tight enough though). |
Sorry, something went wrong.
|
I added tests for tight_layout. |
Sorry, something went wrong.
|
Ah yes. I'm seeing a lot of failures as well. I should hopefully have some time to look into this tomorrow. |
Sorry, something went wrong.
|
See #129 for a fix to most of the regression tests. |
Sorry, something went wrong.
--- This is a patch motivated by Tony Yus work (http://www.mail-archive.com/matplotlib-users@lists.sourceforge.net/msg18107.html). The basic idea is same while implemented slight differently. * no drawing is necessary * support subplots that span multiple rows/columns I also worked on simple guide that demonstrate its functionality (tight_layout_guide.rst). The html copy is here (any help with the documentation will be appreciated). http://dl.dropbox.com/u/178748/Tight%20Layout%20guide%20%E2%80%94%20Matplotlib%20v1.1.0%20documentation.html
This is a patch motivated by Tony Yu's work (http://www.mail-archive.com/matplotlib-users@lists.sourceforge.net/msg18107.html). The basic idea is same while implemented slight differently.
I also worked on simple guide that demonstrate its functionality (tight_layout_guide.rst). The html copy is here (any help with the documentation will be appreciated).
http://dl.dropbox.com/u/178748/Tight%20Layout%20guide%20%E2%80%94%20Matplotlib%20v1.1.0%20documentation.html