FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Avoid 1-tick or 0-tick log-scaled axis. by anntzer · Pull Request #12865 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Avoid 1-tick or 0-tick log-scaled axis. - #12865

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:loglocator-fallbacktoauto
Nov 28, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Avoid 1-tick or 0-tick log-scaled axis.#12865
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:loglocator-fallbacktoauto

Conversation

anntzer commented Nov 22, 2018

Copy link
Copy Markdown
Contributor

... by switching to AutoLocator when the minor LogLocator would produce
no more than one tick.

The examples below come from #8768, which this fixes.

fig, axs = subplots(2)
axs[0].loglog([.53, .41], [.53, .41])
axs[1].loglog([0.45, 0.46], [0.45, 0.46])

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer force-pushed the loglocator-fallbacktoauto branch 2 times, most recently from 26ce31c to c5b9ce4 Compare November 22, 2018 18:54

timhoffm commented Nov 22, 2018

Copy link
Copy Markdown
Member

This looks like the axes have become linear?!?

anntzer commented Nov 22, 2018

Copy link
Copy Markdown
Contributor Author

They haven't, but on such a small range they'll look linear (#8768 (comment)).

dstansby commented Nov 23, 2018

Copy link
Copy Markdown
Member

+lots for this, but definitely an API change so should get a note!

anntzer commented Nov 23, 2018

Copy link
Copy Markdown
Contributor Author

done

jklymak added this to the v3.0.3 milestone Nov 23, 2018

jklymak commented Nov 23, 2018

Copy link
Copy Markdown
Member

putting on the backport queue, though not strictly necessary...

timhoffm commented Nov 23, 2018

Copy link
Copy Markdown
Member

Woops. API change note is not there. Did you forget to push?

jklymak mentioned this pull request Nov 24, 2018
Closed
Avoid 1-tick or 0-tick log-scaled axis.
a918a13 
... by switching to AutoLocator when the minor LogLocator would produce
no more than one tick.
anntzer force-pushed the loglocator-fallbacktoauto branch from c5b9ce4 to a918a13 Compare November 28, 2018 10:19

anntzer commented Nov 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Indeed, it got lost on the way. Fixed.
Dunno if it's 3.0.3 or 3.1 material, not that I really care.

timhoffm merged commit f093129 into matplotlib:master Nov 28, 2018

lumberbot-app Bot commented Nov 28, 2018

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 f0931295930b708cc32a8228430d5cbba991463a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #12865: Avoid 1-tick or 0-tick log-scaled axis.'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-12865-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR #12865 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

anntzer deleted the loglocator-fallbacktoauto branch November 28, 2018 23:27

timhoffm commented Nov 28, 2018

Copy link
Copy Markdown
Member

@jklymak You labelled as 3.0.3. Any interest in backporting? I would be fine with just leaving it in 3.1 as it's not a regression.

jklymak mentioned this pull request Jan 7, 2019
Closed
anntzer mentioned this pull request Jan 7, 2019
Closed
timhoffm mentioned this pull request Jan 12, 2019
Merged
1 of 7 tasks
tacaswell modified the milestones: v3.0.3, v3.1 Jan 12, 2019
anntzer mentioned this pull request Nov 2, 2019
Closed
ImportanceOfBeingErnest mentioned this pull request Jan 27, 2020
Closed
anntzer mentioned this pull request Mar 6, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL