FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Removing hard-coded values used in mplot3d by WeatherGod · Pull Request #137 · matplotlib/matplotlib · GitHub

Repository navigation

Removing hard-coded values used in mplot3d - #137

Merged
ddale merged 1 commit into
matplotlib:masterfrom
WeatherGod:mplot3d/axes3d_simplify
Jun 16, 2011
Merged

ddale merged 1 commit into
matplotlib:masterfrom
WeatherGod:mplot3d/axes3d_simplify

Conversation

Copy link
Copy Markdown
Member

This is the first step in a longer series of changes I would like to make to mplot3d. The first commit is meant to consolidate the hard-coded values used in axis3d objects into a single user-modifiable data structure. Note though that changing any particular value does not necessarily mean that that value would result in a change in appearance (such as pane colors, which has to be set through the axis object's set_pane_color()).

Furthermore, some properties may not immediately correspond intuitively to what is visually seen. For example:

ax.x_axis.set_pane_color([1.0, 0.0, 0.0, 1.0])
ax.y_axis.set_pane_color([0.0, 1.0, 0.0, 1.0])
ax.z_axis.set_pane_color([0.0, 0.0, 1.0, 1.0])

produces a red pane for the yz-plane (upper-left), green pane for the xz-plane (upper-right), and a blue pane for the xy-plane (bottom). This is correct, but would probably be best handled through documentation of a axes3d method that would explain which panel gets colored.

I will see what other changes can be done to this pull request within the next week, but when it comes time to put out the next release, feel free to merge the changes that have been made so far to master.

ddale added a commit that referenced this pull request Jun 16, 2011
Removing hard-coded values used in mplot3d
ddale merged commit 7c1cd9b into matplotlib:master Jun 16, 2011
richbwood mentioned this pull request Dec 19, 2012
WeatherGod deleted the mplot3d/axes3d_simplify branch July 23, 2014 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL