| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| if self._orientation == 'y': | ||
| pscale = self._parent.yaxis.get_scale() | ||
| set_scale = self.set_yscale | ||
| if pscale == self._parentscale: |
There was a problem hiding this comment.
do we want == or is here?
Sorry, something went wrong.
There was a problem hiding this comment.
It's ==, get_scale returns a string. Well really we should retrieve the scale object rather than a scale string, but that's a separate issue...
Sorry, something went wrong.
There was a problem hiding this comment.
One minor comment, but otherwise 👍
Sorry, something went wrong.
|
Merging as 3.2, but @jklymak can backport to 3.1 if he wants :) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
We set the scale for secondary_axis for each draw in case the parent scale has changed (i.e. from linear to log), but this means that we can't set the locators and formatters for the secondary axis. This change keeps track of the parent scale and only resets the locators and formatters if the parent scale changes.
Closes #14443
now works as expected...
PR Checklist