Repository navigation
In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching. - #14592
Merged
jklymak merged 1 commit intoFeb 25, 2020
Merged
jklymak merged 1 commit into
jklymak merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
secondaryformatter
branch
from
650323a to
0e1f13b
Compare
June 20, 2019 22:36
_set_scale checks whether the parent scale changed before modifying the secondary scale. set_functions should do the same. See added test for previously failing case.
anntzer
force-pushed
the
secondaryformatter
branch
from
0e1f13b to
c7f6506
Compare
February 5, 2020 15:24
ImportanceOfBeingErnest
approved these changes
Feb 25, 2020
ImportanceOfBeingErnest
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'm positive about this. Also fixes #15621
Sorry, something went wrong.
jklymak
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_set_scale checks whether the parent scale changed before modifying the
secondary scale. set_functions should do the same. See added test for
previously failing case.
(Basically a followup to #14447.)
PR Summary
PR Checklist