FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

More cleanups. by anntzer · Pull Request #14845 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

More cleanups. - #14845

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:inverted
Jul 19, 2019
ConversationCommits (1)ChecksFiles changed
Merged

More cleanups.#14845
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:inverted

Conversation

anntzer commented Jul 18, 2019

Copy link
Copy Markdown
Contributor
  • transformA + transformB.inverted() === transformA - transformB,
    and give the result a more meaningful name.
  • Other cleanups in axislines.py (which used the above pattern quite a
    bit).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

dstansby commented Jul 18, 2019

Copy link
Copy Markdown
Member

@anntzer can you try and work out why codecov isn't showing up on any of your PRs? I don't really want to review any until it returns...

anntzer commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

I don't know why they don't show up on the gh interface, but they're actually being run; this PR is at https://codecov.io/gh/matplotlib/matplotlib/commit/2b4a3af41cb1168ef137efe5a2c052c3c735007d (you can find them under "recent commits" at https://codecov.io/gh/matplotlib/matplotlib).

dstansby commented Jul 18, 2019

Copy link
Copy Markdown
Member

Could you perhaps check with codecov why they're not showing up? Not having them easy to access/see just adds more effort on top of the already congested PR queue!

anntzer commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

sure, will do

More cleanups.
7bf0185 
- `transformA + transformB.inverted()` === `transformA - transformB`,
  and give the result a more meaningful name.
- Other cleanups in axislines.py (which used the above pattern quite a
  bit).
anntzer mentioned this pull request Jul 18, 2019
Merged
6 tasks

anntzer commented Jul 19, 2019

Copy link
Copy Markdown
Contributor Author

It's here now, it looks like it's just very delayed.

QuLogic added this to the v3.2.0 milestone Jul 19, 2019
QuLogic merged commit 18bc802 into matplotlib:master Jul 19, 2019
anntzer deleted the inverted branch July 19, 2019 09:30
anntzer mentioned this pull request Oct 1, 2019
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL