Repository navigation
Fix broken imports. - #15356
Merged
tacaswell merged 1 commit intoOct 2, 2019
Merged
Fix broken imports.#15356tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- Fix broken imports. - Workaround Arc bug.
anntzer
force-pushed
the
broken-imports
branch
from
bad56a8 to
4677fd9
Compare
October 1, 2019 19:52
anntzer
commented
Oct 1, 2019
Comment thread
lib/matplotlib/patches.py
| box_path = Path.unit_rectangle() | ||
| box_path_transform = (transforms.BboxTransformTo(self.axes.bbox) | ||
| - self.get_transform()) | ||
| + self.get_transform().inverted()) |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
this is less precise (box_path gets some ~1e-19 errors) but is needed to make Arc work...
Sorry, something went wrong.
jklymak
approved these changes
Oct 1, 2019
Copy link
Copy Markdown
Member
|
Does this need to be back ported to 3.2? Or can we milestone it 3.3? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jun 17, 2020
Merge pull request matplotlib#17564 from tacaswell/fix_big_arc FIX: big arc code path Conflicts: lib/matplotlib/patches.py - implicitly backport a change from matplotlib#15356 (from `- trans ` -> `+ trans.inverted()`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
... due to #15210 crossing wires with other PRs.
Also needed to revert part of #14845 (cleanup) which exposed some of the issues hinted at in #14694.
will self-merge on CI pass.
PR Checklist