MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning by tacaswell · Pull Request #15168 · matplotlib/matplotlib · GitHub

This is a workaround to https://bugs.python.org/issue37980

np.bool raises a warning if you try to use it as an index (by
warning in its __index__ method
in py38 bpo-36048: Use __index__() instead of __int__() for implicit conversion if available. python/cpython#11952 python changes
the code path used to convert np.bool_ -> int for as it is used in
sorted so it now goes through the __index__ code path
this causes a bunch of spurious warnings to come out of Matplotlib.

I see failures on this locally, but we do not see these failures on the azure pre-release, not sure why.

PR Summary

PR Checklist

Has Pytest style unit tests
Code is Flake 8 compliant

force-pushed to fix spelling 🙄

ok, I figured out why the python preview is not failing on azure, we are installing py3.8b4, but in the tests are falling back to py3.6.8.

This seems to be hitting https://bugs.python.org/issue37074 which looks like it has been fixed, but not an a tagged pre-release yet.

This is a workaround to https://bugs.python.org/issue37980 - np.bool raises a warning if you try to use it as an index (by warning in its `__index__` method - in py38 python/cpython#11952 python changes the code path used to convert `np.bool_` -> int for as it is used in `sorted` so it now goes through the `__index__` code path - this causes a bunch of spurious warnings to come out of Matplotlib.

I just force-pushed a commit with in-line comments of why we are doing extra work, will open a PR later today with the "fix" to the azure pre-release python.

Although there is a chance that CPython will fix this before py3.8 is released, there is also a chance that they will decide that this is a NumPy problem so I think we should defensively merge this so we do not have to hold any release on a decision being made upstream (either in NumPy or Python).

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v2.2.x
$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 b965c4d4603caac702fa2530ac88d35dd3bb4df9

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #15168: MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning'

Push to a named branch :

git push YOURFORK v2.2.x:auto-backport-of-pr-15168-on-v2.2.x

Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR #15168 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

…o prevent deprecation warning

…168-on-v3.1.x Backport PR #15168 on branch v3.1.x (MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning)

this code path is not in 2.2.x, these changes came in via 7f7b048 which is only in 3.1.1+

FTR, this works for Python 3.8.0b4: https://koji.fedoraproject.org/koji/taskinfo?taskID=37504715

tacaswell added this to the v2.2.5 milestone Sep 1, 2019

tacaswell mentioned this pull request Sep 1, 2019

TST: verify warnings fail the test suite #15169

Merged

2 tasks done

tacaswell requested a review from QuLogic September 2, 2019 18:20

tacaswell mentioned this pull request Sep 2, 2019

regression in py38 with bool-as-index deprecation warning numpy/numpy#14397

Open

tacaswell force-pushed the mnt_py38_npbool_warnings branch from 181dcf1 to 6df091f Compare September 2, 2019 19:40

tacaswell changed the title MNT: explicitly cast np.bool_ -> bool to prevent derpcation warnings MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning Sep 2, 2019

tacaswell force-pushed the mnt_py38_npbool_warnings branch from f87f7b4 to 6df091f Compare September 3, 2019 19:49

dstansby approved these changes Sep 4, 2019

View reviewed changes

tacaswell force-pushed the mnt_py38_npbool_warnings branch from 6df091f to 3c93e41 Compare September 4, 2019 15:57

jklymak merged commit b965c4d into matplotlib:master Sep 4, 2019

lumberbot-app Bot added the Still Needs Manual Backport label Sep 4, 2019

meeseeksmachine mentioned this pull request Sep 4, 2019

Backport PR #15168 on branch v3.1.x (MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning) #15185

Merged

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 4, 2019

Backport PR matplotlib#15168 : MNT: explicitly cast np.bool_ -> bool t…

4651a12

…o prevent deprecation warning

tacaswell added a commit that referenced this pull request Sep 4, 2019

Merge pull request #15185 from meeseeksmachine/auto-backport-of-pr-15…

1191549

…168-on-v3.1.x Backport PR #15168 on branch v3.1.x (MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning)

tacaswell deleted the mnt_py38_npbool_warnings branch September 4, 2019 19:46

tacaswell modified the milestones: v2.2.5, v3.1.2 Sep 5, 2019

tacaswell removed the Still Needs Manual Backport label Sep 5, 2019

tacaswell mentioned this pull request Sep 18, 2019

CI: use python -m to make sure we are using the pip/pytest we want #15300

Closed

dstansby mentioned this pull request Oct 11, 2019

Fix DeprecationWarning in nightly testing #15403

Merged

bsipocz mentioned this pull request Oct 15, 2019

Adding python3.8 testing astropy/astropy#9366

Merged

anntzer mentioned this pull request Nov 13, 2019

Should xlim support single-entry arrays? #15690

Closed

MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning by tacaswell · Pull Request #15168 · matplotlib/matplotlib · GitHub

Repository navigation

MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning - #15168

MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning#15168
jklymak merged 1 commit into
matplotlib:masterfrom
tacaswell:mnt_py38_npbool_warnings

tacaswell commented Sep 1, 2019

Uh oh!

tacaswell commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 4, 2019

Uh oh!

tacaswell commented Sep 4, 2019

Uh oh!

lumberbot-app Bot commented Sep 4, 2019

Uh oh!

tacaswell commented Sep 5, 2019

Uh oh!

QuLogic commented Sep 7, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning by tacaswell · Pull Request #15168 · matplotlib/matplotlib · GitHub

Repository navigation

MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning - #15168

MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning#15168jklymak merged 1 commit intomatplotlib:mastermatplotlib/matplotlib:masterfrom tacaswell:mnt_py38_npbool_warningstacaswell/matplotlib:mnt_py38_npbool_warningsCopy head branch name to clipboard

Conversation

tacaswell commented Sep 1, 2019

PR Summary

PR Checklist

Uh oh!

tacaswell commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 2, 2019

Uh oh!

tacaswell commented Sep 4, 2019

Uh oh!

tacaswell commented Sep 4, 2019

Uh oh!

lumberbot-app Bot commented Sep 4, 2019

Uh oh!

tacaswell commented Sep 5, 2019

Uh oh!

QuLogic commented Sep 7, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MNT: explicitly cast np.bool_ -> bool to prevent deprecation warning#15168
jklymak merged 1 commit into
matplotlib:masterfrom
tacaswell:mnt_py38_npbool_warnings