FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CI: use python -m to make sure we are using the pip/pytest we want by tacaswell · Pull Request #15300 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

CI: use python -m to make sure we are using the pip/pytest we want - #15300

Closed
tacaswell wants to merge 1 commit into
matplotlib:masterfrom
tacaswell:tst_azure_envs
ConversationCommits (1)ChecksFiles changed
Closed

CI: use python -m to make sure we are using the pip/pytest we want#15300
tacaswell wants to merge 1 commit into
matplotlib:masterfrom
tacaswell:tst_azure_envs

Conversation

tacaswell commented Sep 18, 2019

Copy link
Copy Markdown
Member

PR Summary

Follow up to work in #15168 that discovered we were not actually using the envs we thought we were (as we were not seeing the warnings on 3.8).

Expect this to fail on the 3.8.0b4 for the same reason as #15295

tacaswell added this to the v3.2.0 milestone Sep 18, 2019
timhoffm approved these changes Sep 19, 2019
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, conditional on CI pass.

jklymak commented Sep 25, 2019

Copy link
Copy Markdown
Member

Indeed ti does fail as per #15295. Confused about what we want to do about that? Do you want this merged with the breaking build?

jklymak added the Build label Sep 25, 2019

tacaswell commented Sep 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

We should re-run the test when 3.8rc1 comes out (should be in a week or two).

[edited to fix typo in version]

anntzer commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

We should re-run the test when 2.8rc1 comes out (should be in a week or two).

(mumbles snarky comment about how Guido finally gave in and decided to do a 2.8 release after all ;))

tacaswell closed this Oct 3, 2019
tacaswell reopened this Oct 3, 2019

tacaswell commented Oct 3, 2019

Copy link
Copy Markdown
Member Author

power-cycled to restart CI now that 3.8.0rc1 is available.

tacaswell commented Oct 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

It looks like we are still failing on the python pre-release, but in a different way when compiling numpy....

dstansby mentioned this pull request Oct 14, 2019
Merged

tacaswell commented Oct 14, 2019

Copy link
Copy Markdown
Member Author

Closing in favor of #15418

tacaswell closed this Oct 14, 2019
tacaswell deleted the tst_azure_envs branch October 14, 2019 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Build

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL