FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve docs on automated tests by timhoffm · Pull Request #17040 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Improve docs on automated tests - #17040

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
timhoffm:doc-test
Apr 17, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Improve docs on automated tests#17040
QuLogic merged 1 commit into
matplotlib:masterfrom
timhoffm:doc-test

Conversation

timhoffm commented Apr 5, 2020

Copy link
Copy Markdown
Member

PR Summary

  • Mention Azure pipelines
  • Add tips for finding the cause of failed tests.
  • Mention that Codecov and LGTM are for information only, i.e. not necessarily a blocker for merging.

QuLogic commented Apr 6, 2020

Copy link
Copy Markdown
Member

Do you also want to mention that Azure has image artifacts if a tests fail?

timhoffm commented Apr 7, 2020

Copy link
Copy Markdown
Member Author

Makes sense. Would you mind adding a description how to find these? I don't have a clear picture of that yet.

timhoffm commented Apr 11, 2020
View reviewed changes
Comment thread doc/devel/coding_guide.rst
A core dev should only champion one PR at a time and we should try to keep
the flow of championed PRs reasonable.

* Do not self merge, except for 'small' patches to un-break the CI or

timhoffm Apr 5, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've moved this section to the Merging section to here because it covers mergin not automated tests.

timhoffm added this to the v3.3.0 milestone Apr 11, 2020

QuLogic commented Apr 14, 2020

Copy link
Copy Markdown
Member

Unfortunately, I don't see any quick link to artifacts. Feel free to massage this into something useful:

Go to the Azure check, and click "View more details on Azure Pipelines". If you clicked on the overview, then the "Related" section should list a "# artifacts" link. If you clicked on a Job, then there should be a "# artifacts" link in the log.

Note, you won't see it on this PR because they're only posted on failure to save space.

timhoffm commented Apr 16, 2020

Copy link
Copy Markdown
Member Author

Added a section on image artifacts on Azure.

QuLogic merged commit 30d1396 into matplotlib:master Apr 17, 2020
QuLogic mentioned this pull request Apr 17, 2020
Merged
1 task done
timhoffm deleted the doc-test branch April 17, 2020 06:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL