| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
So it doesn't post here because the token is for the PR repo and not this repo. I'm not sure if that will fix itself once merged. Considering also adding cppcheck and eslint, but there's a bug in reviewdog preventing the latter. We could also add some things like misspell or languagetool, but I'm not sure if we want to (hard to say for technical things how useful spell-check is.) |
Sorry, something went wrong.
|
@tacaswell ran a test PR for me here: QuLogic#5 Unfortunately, PRs don't get writable tokens for Checks API, so it won't post its separate Check with the annotation like in my test. That's a bit disappointing, but at least it's not hidden inside Travis checks now. There are a couple of other token/review options that I will check, but if none is better, I'll rename some of the stages to make it more obvious what to look at on error. |
Sorry, something went wrong.
|
Ah wait, I'm totally blind. The fallback annotations do show up; they just aren't on the sub-job, but the top-level "Linting" section. |
Sorry, something went wrong.
Sorry, something went wrong.
|
If you're looking for spellchecking in code, you can also look at codespell. |
Sorry, something went wrong.
|
I ran codespell and opened #17184, though there are still several false positives that might impede enabling it on PRs immediately. |
Sorry, something went wrong.
|
Is there still something to do on this PR or can it be merged? |
Sorry, something went wrong.
|
It can be merged; that's why it's no longer draft. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
This moves flake8 from Travis to GitHub Actions using reviewdog to post it to the GitHub Checks. It runs a bit faster now (basically all time is running flake8 vs ~0 install time) at ~1m vs ~5.5m on Travis.
Linting will appear as a section separate from Travis now in the Checks section of the PR, but I could switch the config to post a review.
Here is the PR I'm using to test out the results.
PR Checklist