Repository navigation
Warn on invalid savefig keyword arguments - #17223
Merged
QuLogic merged 4 commits intoJun 15, 2020
Merged
QuLogic merged 4 commits into
QuLogic merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
QuLogic
force-pushed
the
savefig-extra-kwargs
branch
from
0bd3491 to
cb47539
Compare
April 23, 2020 06:02
QuLogic
force-pushed
the
savefig-extra-kwargs
branch
from
cb47539 to
f74575c
Compare
June 10, 2020 19:09
QuLogic
marked this pull request as ready for review
June 10, 2020 19:13
Copy link
Copy Markdown
Member
Author
|
Now ready, as the metadata PRs went in. |
Sorry, something went wrong.
tacaswell
approved these changes
Jun 10, 2020
anntzer
reviewed
Jun 11, 2020
Comment thread
lib/matplotlib/backends/backend_agg.py
Outdated
anntzer
reviewed
Jun 11, 2020
Comment thread
lib/matplotlib/backend_bases.py
Outdated
QuLogic
force-pushed
the
savefig-extra-kwargs
branch
from
f74575c to
f25f1eb
Compare
June 12, 2020 01:02
Copy link
Copy Markdown
Member
Author
|
I changed it into a decorator, as @anntzer requested. I wonder if also args should be removed from the final methods? |
Sorry, something went wrong.
QuLogic
force-pushed
the
savefig-extra-kwargs
branch
from
f25f1eb to
b7a574f
Compare
June 12, 2020 01:24
Copy link
Copy Markdown
Contributor
|
Also removing args seems good to me? |
Sorry, something went wrong.
anntzer
approved these changes
Jun 15, 2020
Copy link
Copy Markdown
Contributor
|
postci |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This depends on #17221 and #17233 so that there are no warnings about metadata from saving SVG or PDF with the PGF backend.
Fixes #192.
PR Checklist