FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added the "cleared" method to Path, and updated the path module's documentation. by pelson · Pull Request #2011 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Added the "cleared" method to Path, and updated the path module's documentation. - #2011

Merged
mdboom merged 2 commits into
matplotlib:masterfrom
pelson:api_changes_sketch
May 21, 2013
ConversationCommits (2)ChecksFiles changed
Merged

Added the "cleared" method to Path, and updated the path module's documentation.#2011
mdboom merged 2 commits into
matplotlib:masterfrom
pelson:api_changes_sketch

Conversation

pelson commented May 15, 2013

Copy link
Copy Markdown
Member

No description provided.

mdboom reviewed May 15, 2013
View reviewed changes
Comment thread lib/matplotlib/path.py Outdated

mdboom May 15, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Might as well do this in numpydoc format as well, while we're at it.

pelson commented May 20, 2013

Copy link
Copy Markdown
Member Author

Ok. Think this is now ready @mdboom.

mdboom reviewed May 20, 2013
View reviewed changes
Comment thread lib/matplotlib/path.py

mdboom May 20, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we keep this as it was -- I know it doesn't really matter, but there are some tricks used to detect the end of paths that are made more obvious when you think of it in hex.

pelson May 20, 2013

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

but there are some tricks used to detect the end of paths that are made more obvious when you think of it in hex

For whom? I can see the benefit for developers, but not for everyday users. I'd be happy to add a comment here to jig the readers memory, if that would suffice?

mdboom May 20, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok -- probably simplest to leave it as a (base 10) number, then. A comment here doesn't make sense either.

mdboom commented May 20, 2013

Copy link
Copy Markdown
Member

I still think we should have cleaned return a Path instance -- we can bypass the constructor to make it nice and fast. It just seems unpythonic this way, to me at least.

pelson commented May 20, 2013

Copy link
Copy Markdown
Member Author

I still think we should have cleaned return a Path instance

The two cases I can envisage with cleared both just use the codes and verts. That said, I'm happy enough to compromise and have implemented a fast constructor for Path.

Was that the kind of thing you had in mind?

mdboom commented May 20, 2013

Copy link
Copy Markdown
Member

Yes -- that's basically what I had in mind. I think that's handy. There may be other cases in there where this should be used instead of the constructor, but that can wait for another PR.

pelson mentioned this pull request May 21, 2013
Merged

pelson commented May 21, 2013

Copy link
Copy Markdown
Member Author

Should add ... here so that those things are set correctly in the result.

Nice. I've added a commit. I expect to have to rebase this PR after the deprecations PR gets merged.

pelson commented May 21, 2013

Copy link
Copy Markdown
Member Author

Other than that, I think this PR is good to go... Thanks for being patient with me ;)

No worries. Having your invaluable feedback on this module has been great.

I'll rebase now.

pelson commented May 21, 2013

Copy link
Copy Markdown
Member Author

Ok. Once travis does its thing, lets merge 😄

pelson commented May 21, 2013

Copy link
Copy Markdown
Member Author

Other than the spurious test failiure from master, the tests are passing with this PR.

mdboom added a commit that referenced this pull request May 21, 2013
Merge pull request #2011 from pelson/api_changes_sketch
24a635f 
Added the "cleared" method to Path, and updated the path module's documentation.
mdboom merged commit 24a635f into matplotlib:master May 21, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL