FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Deprecations and housecleaning by mdboom · Pull Request #2026 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Deprecations and housecleaning - #2026

Merged
pelson merged 11 commits into
matplotlib:masterfrom
mdboom:deprecations-pre-13
May 21, 2013
ConversationCommits (11)ChecksFiles changed
Merged

Deprecations and housecleaning#2026
pelson merged 11 commits into
matplotlib:masterfrom
mdboom:deprecations-pre-13

Conversation

mdboom commented May 20, 2013

Copy link
Copy Markdown
Member

This PR ties up a number of related issues:

This also brings over a helper function and decorator originally written by @iguananaut for the astropy project that makes it easier to mark functions as deprecated. This also unifies the interface for deprecated things and makes it easier to search later for things that are due for removal (that should make this kind of PR a little easier next time).

efiring reviewed May 20, 2013
View reviewed changes
Comment thread matplotlibrc.template Outdated

efiring May 20, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FltkAgg is also removed, so it needs to be deleted from this comment.

efiring commented May 20, 2013

Copy link
Copy Markdown
Member

Wow! Thanks for putting all that together. It looks like the test failure with 2.6 is completely unrelated.

pelson reviewed May 21, 2013
View reviewed changes
Comment thread lib/matplotlib/cbook.py Outdated

pelson May 21, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Missing to.

pelson commented May 21, 2013

Copy link
Copy Markdown
Member

@mdboom - I've added a couple of trivial actions. If you just add a commit on top of 85f1966 (or alternatively ammend the last commit, leaving 3dab377 static) I'd be happy to merge this ASAP. This will conflict with #2011 but given the size of this PR, I'm happy to have to resolve that conflict in my PR.

Awesome! I think this is the best PR I've seen on mpl - I'm a big fan of deleting code 😄

pelson added a commit that referenced this pull request May 21, 2013
Merge pull request #2026 from mdboom/deprecations-pre-13
3586394 
Major deprecations and housecleaning for v1.3
pelson merged commit 3586394 into matplotlib:master May 21, 2013
This was referenced May 21, 2013
Closed
Closed
Closed
mdboom deleted the deprecations-pre-13 branch August 7, 2014 13:52
tacaswell mentioned this pull request Feb 11, 2018
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.3.x blocker

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL