FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Issue Fix #21959 by 35C4n0r · Pull Request #22130 · matplotlib/matplotlib · GitHub

Repository navigation

Issue Fix #21959 - #22130

Closed
35C4n0r wants to merge 2 commits into
matplotlib:mainfrom
35C4n0r:edit-1
Closed

35C4n0r wants to merge 2 commits into
matplotlib:mainfrom
35C4n0r:edit-1

Conversation

35C4n0r commented Jan 6, 2022 •
edited
Loading

Copy link
Copy Markdown

In case of ValueError caused by user given input, raw string will be displayed in Error Message.
Example:

raise ValueError(
                        f"'c' argument must be a color, a sequence of colors, "
                        f"or a sequence of numbers, not {c!r}")

PR Summary

PR Checklist

Tests and Styling

  • [N/A ] Has pytest style unit tests (and pytest passes).
  • [N/A ] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [ N/A] New features are documented, with examples if plot related.
  • [N/A ] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [ N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

In case of ValueError caused by user given input, raw string will be displayed in Error Message.

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Error on line 6601 fixed.
QuLogic added the status: needs workflow approval For PRs from new contributors, from which GitHub blocks workflows by default. label Jan 7, 2022

QuLogic commented Jan 7, 2022

Copy link
Copy Markdown
Member

Please give you PR/commit message more informative titles. No-one's going to click on a PR to review if the message doesn't say anything that they understand.

jklymak commented Jan 20, 2022

Copy link
Copy Markdown
Member

Thanks for this. You have a flake8 error, and your new test isn't passing. I've moved to draft until you can fix it. Thanks,

jklymak marked this pull request as draft January 20, 2022 08:27

QuLogic commented Nov 10, 2022

Copy link
Copy Markdown
Member

Replaced by #24403.

QuLogic closed this Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs revision status: needs workflow approval For PRs from new contributors, from which GitHub blocks workflows by default.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL