FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use `repr` in error message Addresses #21959 by jefromyers · Pull Request #24403 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Use repr in error message Addresses #21959 - #24403

Merged
QuLogic merged 6 commits into
matplotlib:mainfrom
jefromyers:repr-instead-of-str
Nov 10, 2022
ConversationCommits (6)ChecksFiles changed
Merged

Use repr in error message Addresses #21959#24403
QuLogic merged 6 commits into
matplotlib:mainfrom
jefromyers:repr-instead-of-str

Conversation

jefromyers commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Implements the proposed solution in issue #21959. Error message now outputs the user’s input via repr.

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [N/A] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [N/A] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

github-actions Bot reviewed Nov 8, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

story645 linked an issue Nov 8, 2022 that may be closed by this pull request
[ENH]: Use repr instead of str in the error message #21959
Closed
QuLogic reviewed Nov 9, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_axes.py Outdated
QuLogic reviewed Nov 9, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_axes.py Outdated

QuLogic commented Nov 10, 2022

Copy link
Copy Markdown
Member

Do you mind if I squash merge this PR, or would you like to?

jefromyers commented Nov 10, 2022

Copy link
Copy Markdown
Contributor Author

feel free to squash, sir. thanks for your help.

QuLogic added this to the v3.7.0 milestone Nov 10, 2022
QuLogic merged commit 04ce3e9 into matplotlib:main Nov 10, 2022

QuLogic commented Nov 10, 2022

Copy link
Copy Markdown
Member

Thanks @jefromyers! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

QuLogic mentioned this pull request Nov 10, 2022
Closed
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
Use repr in scatter error message (matplotlib#24403)
547460f 
* use repr in error message closes matplotlib#21959

* add test for repr error message

* fix formatting

* clean up formatting and naming

* add `pragma: no cover`

* remove import and function name a bit more explicit
story645 mentioned this pull request Jan 22, 2023
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
QuLogic QuLogic approved these changes
story645 story645 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

First Time Contributors
Status: Merged

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

[ENH]: Use repr instead of str in the error message

3 participants

Back | FazBrowse Home | New Git URL