FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Disable QuadMesh cursor data by default by dstansby · Pull Request #22254 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Disable QuadMesh cursor data by default - #22254

Merged
tacaswell merged 1 commit into
matplotlib:mainfrom
dstansby:quad-mesh-cursor
Jan 20, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Disable QuadMesh cursor data by default#22254
tacaswell merged 1 commit into
matplotlib:mainfrom
dstansby:quad-mesh-cursor

Conversation

dstansby commented Jan 17, 2022

Copy link
Copy Markdown
Member

PR Summary

For moderately sized QuadMeshes getting the cursor data is very slow - see #21917 (comment). As such, disable by default for now, but allow users to manually enable it.

Fixes #22253
Fixes #21917

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

dstansby added this to the v3.5.2 milestone Jan 17, 2022
dstansby requested a review from anntzer January 17, 2022 19:59
dstansby added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 17, 2022
tacaswell reviewed Jan 17, 2022
View reviewed changes
Comment thread lib/matplotlib/collections.py Outdated

Attributes
----------
show_cursor_data : bool

tacaswell Jan 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we have a comparable API on anything else?

dstansby Jan 18, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Searching the docs for cursor_data suggests we don't.

jklymak Jan 18, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we want to make this a general Artist API, and set as appropriate for different artists (like set_snap, set_in_layout, etc)?

dstansby Jan 20, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This sounds like a good idea, but maybe not for a bugfix release.

oscargus reviewed Jan 17, 2022
View reviewed changes
Comment thread doc/api/next_api_changes/behavior/22254-DS.rst Outdated
oscargus reviewed Jan 17, 2022
View reviewed changes
Comment thread lib/matplotlib/collections.py Outdated

anntzer commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

I agree the slowness isn't really acceptable. No strong opinion as to the exact control API (well, perhaps a vague preference for a setter/getter for API consistency, but heh).

dstansby commented Jan 18, 2022

Copy link
Copy Markdown
Member Author

No strong opinion as to the exact control API (well, perhaps a vague preference for a setter/getter for API consistency, but heh).

Do we have any general policy or preference for attribute vs. property vs. getter/setter? I'm also open to any, but attribute was the fewest lines of code to implement 😄

anntzer commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

I don't know policy-wise, but the statu quo would certainly be a setter.

tacaswell merged commit 0406c46 into matplotlib:main Jan 20, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 20, 2022
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
61d4f69
meeseeksmachine mentioned this pull request Jan 20, 2022
Merged
QuLogic added a commit that referenced this pull request Jan 20, 2022
Merge pull request #22275 from meeseeksmachine/auto-backport-of-pr-22…
b808483 
…254-on-v3.5.x

Backport PR #22254 on branch v3.5.x (Disable QuadMesh cursor data by default)
jklymak mentioned this pull request Mar 23, 2022
Merged
6 tasks
This was referenced Mar 23, 2022
Merged
Closed
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
5779fc5
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
ac24b65
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
ac834f4
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
1606268
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
1809478
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
afcec63
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
ff0754f
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
3ad282f
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
05b2c6f
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
2318e70
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22254: Disable QuadMesh cursor data by default
7771c77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell left review comments
jklymak jklymak left review comments
oscargus oscargus left review comments
anntzer anntzer approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.5.2

Development

Successfully merging this pull request may close these issues.

pcolormesh freezes window when zooming/panning [Bug]: pcolormesh is not responsive in Matplotlib 3.5

5 participants

Back | FazBrowse Home | New Git URL