FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove QuadMesh from mouseover set. by anntzer · Pull Request #22693 · matplotlib/matplotlib · GitHub

Repository navigation

Remove QuadMesh from mouseover set. - #22693

Merged
jklymak merged 1 commit into
matplotlib:mainfrom
anntzer:qmo
Mar 24, 2022
Merged

jklymak merged 1 commit into
matplotlib:mainfrom
anntzer:qmo

Conversation

anntzer commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Closes #22520.
Replaces (IMO) #22691.
I think #22254 should be reverted, as the knob it introduces doesn't actually work and the desired knob already exists (it's the mouseover property).

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 23, 2022
anntzer added this to the v3.5.2 milestone Mar 23, 2022

Copy link
Copy Markdown
Member

Should this be documented and giving the user instruction how to reenable it if they want cursor data ( at the risk of being slow)?

jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes this works too...

jklymak commented Mar 24, 2022

Copy link
Copy Markdown
Member

I'll merge this as is, because it unbreaks Matplotlib master. We can follow up with docs if we want to point users to this functionality.

jklymak merged commit 6b2d3f2 into matplotlib:main Mar 24, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 24, 2022
anntzer deleted the qmo branch March 24, 2022 09:31
oscargus added a commit that referenced this pull request Mar 24, 2022
…693-on-v3.5.x

Backport PR #22693 on branch v3.5.x (Remove QuadMesh from mouseover set.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Slow lasso selector over QuadMesh collection

4 participants


Back | FazBrowse Home | New Git URL