FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use repr in error messages by oscargus · Pull Request #22712 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Use repr in error messages - #22712

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
oscargus:reprinerrors
Apr 7, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Use repr in error messages#22712
timhoffm merged 1 commit into
matplotlib:mainfrom
oscargus:reprinerrors

Conversation

oscargus commented Mar 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Related to #21959

Added tests for some of the errors.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

oscargus marked this pull request as draft March 28, 2022 06:08
oscargus force-pushed the reprinerrors branch 5 times, most recently from 2c8c6c9 to 985c73d Compare March 28, 2022 11:19
oscargus marked this pull request as ready for review March 28, 2022 11:34
oscargus mentioned this pull request Mar 29, 2022
Merged
6 tasks
oscargus force-pushed the reprinerrors branch 2 times, most recently from 3e617ff to 498f462 Compare March 30, 2022 07:33
timhoffm reviewed Mar 30, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_axes.py Outdated
Comment thread lib/matplotlib/tests/test_text.py Outdated
oscargus added this to the v3.6.0 milestone Apr 4, 2022
matplotlib deleted a comment from oscargus Apr 5, 2022

QuLogic commented Apr 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

QuLogic deleted a comment from oscargus 30 seconds ago

Wait, what? I thought I was deleting a pending comment of mine. I don't know what got deleted now.

QuLogic closed this Apr 5, 2022
QuLogic reopened this Apr 5, 2022

timhoffm commented Apr 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

We'll never know what got deleted ... 🪄

Still this PR looks fine, so I merge as is.

timhoffm merged commit 0e46ff2 into matplotlib:main Apr 7, 2022
oscargus deleted the reprinerrors branch April 7, 2022 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Maintenance

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL