FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix and test deprecated layout method toggling by richardsheridan · Pull Request #22849 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

fix and test deprecated layout method toggling - #22849

Closed
richardsheridan wants to merge 1 commit into
matplotlib:mainfrom
richardsheridan:toggle_layout
ConversationCommits (1)ChecksFiles changed
Closed

fix and test deprecated layout method toggling#22849
richardsheridan wants to merge 1 commit into
matplotlib:mainfrom
richardsheridan:toggle_layout

Conversation

richardsheridan commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #22847. Not sure if there are knock-on effects, looking forward to code review.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

richardsheridan requested a review from jklymak April 14, 2022 18:43

jklymak commented Apr 14, 2022

Copy link
Copy Markdown
Member

Just a heads up that I cannot review anything properly for a week or so. Thanks!

QuLogic added this to the v3.6.0 milestone Apr 15, 2022

greglucas commented May 1, 2022

Copy link
Copy Markdown
Contributor

Is None the "null"-layout engine? It looks like there is also mention of the string "none" here:
#22452
So, I'm curious if this is currently allowed, or if that PR needs to go in first?

jklymak marked this pull request as draft June 30, 2022 08:45

richardsheridan commented Aug 10, 2022

Copy link
Copy Markdown
Contributor Author

Any interest in doing this for 3.5.3 and saving #22452 for 3.6.0?

tacaswell commented Aug 11, 2022

Copy link
Copy Markdown
Member

Sorry, I missed this entirely until I saw it was closed! In the future, please err on the side of re-milestoning things back if you want them to be in a bug fix release.

The reason #22452 picked up all of the extra complexity is that just setting it back to None could end up breaking the colorbars so I would still be wary of this fix.

QuLogic modified the milestones: v3.6.0, unassigned Sep 9, 2022
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Jan 10, 2023
Fix toggle layout engines
0e3b047 
Re-uses the tests from matplotlib#22849, but also tests that going _back_ on works
as well.

Fixes matplotlib#22847

Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Jan 10, 2023
Fix toggling layout engines
f228949 
Re-uses the tests from matplotlib#22849, but also tests that going _back_ on works
as well.

Fixes matplotlib#22847

Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
QuLogic mentioned this pull request Jan 10, 2023
Merged
1 task done
richardsheridan deleted the toggle_layout branch March 31, 2023 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

timhoffm timhoffm approved these changes
jklymak Awaiting requested review from jklymak

Assignees

No one assigned

Labels

status: waiting for other PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot toggle set_tight_layout

6 participants

Back | FazBrowse Home | New Git URL