FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix toggling layout engines by QuLogic · Pull Request #24924 · matplotlib/matplotlib · GitHub

Repository navigation

Fix toggling layout engines - #24924

Merged
jklymak merged 1 commit into
matplotlib:mainfrom
QuLogic:layout-toggles
Jan 10, 2023
Merged

jklymak merged 1 commit into
matplotlib:mainfrom
QuLogic:layout-toggles

Conversation

QuLogic commented Jan 10, 2023

Copy link
Copy Markdown
Member

PR Summary

Re-uses the tests from #22849, but also tests that going back on works as well.

Fixes #22847

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Re-uses the tests from matplotlib#22849, but also tests that going _back_ on works
as well.

Fixes matplotlib#22847

Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
QuLogic added the topic: geometry manager LayoutEngine, Constrained layout, Tight layout label Jan 10, 2023
QuLogic added this to the v3.7.0 milestone Jan 10, 2023
jklymak merged commit e0dc18d into matplotlib:main Jan 10, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 10, 2023
QuLogic deleted the layout-toggles branch January 10, 2023 23:43
QuLogic added a commit that referenced this pull request Jan 10, 2023
…924-on-v3.7.x

Backport PR #24924 on branch v3.7.x (Fix toggling layout engines)
ksunden mentioned this pull request Feb 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: geometry manager LayoutEngine, Constrained layout, Tight layout

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot toggle set_tight_layout

3 participants


Back | FazBrowse Home | New Git URL