Repository navigation
changed colorbar outline from a Line2D object to a Polygon object - #2352
Merged
dmcdougall merged 3 commits intoAug 29, 2013
Merged
dmcdougall merged 3 commits into
dmcdougall merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
lib/matplotlib/colorbar.py
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The default zorder is 2 for Line2D and 1 for Patch objects, so maybe the zorder should be explicitly set to 2 here.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
done
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Obviously, as an API change, this will need some documentation, but other than that I have no hold-ups from switching from Line2D to Polygon. 👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I guess this answers my question of if this really should have targeted 1.3.x instead of master. added entry to api_changes.rst |
Sorry, something went wrong.
dmcdougall
added a commit
that referenced
this pull request
Aug 29, 2013
changed colorbar outline from a Line2D object to a Polygon object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #2296