| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I think this makes sense! |
Sorry, something went wrong.
|
I don't think the failing tests are connected to this PR 😟 |
Sorry, something went wrong.
|
Test failures are unrelated. |
Sorry, something went wrong.
|
I wrote alt text for the what's new entry here but should I just put that as a follow up so this doesn't go through another round of reviews? |
Sorry, something went wrong.
|
You can add it here if you want to update and get #24921 in to fix CI. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good - just one question, which is either a quick fix or I'm missing something. Either way happy for this to be merged once it's been considered!
Sorry, something went wrong.
reworded pctdistance and labeldistance b/c of matplotlib#24789 Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com> Co-authored-by: sledziu32 <sledziu32@gmail.com> Co-authored-by: Jody Klymak <jklymak@gmail.com>
…470-on-v3.7.x Backport PR #24470 on branch v3.7.x ([ENH] hatch keyword for pie + some pie documentation)
| Back | FazBrowse Home | New Git URL |
PR Summary
Added the ability to pass in a list of wedgeproperty dicts, one for each wedge of the pie. Follow on to #2923, would probably address #3134 , inspired by twitter convo
Yes, I know it can be achieved via loop - see the fig comparison test in this PR - but we were already looping over the wedges inside the function to set all the other properties so the major addition is testing if the input is a dict or list of dicts. <- this could possibly be factored into a cbook function, my guess being 'if thing not list wrap in repeat' is not uncommon in the codebase.
Current Iteration
which would produce roughly
I'll put in a what's new and example if there's consensus on this going in.
PR Checklist
Tests and Styling
Documentation
Release Notes